Autovot support PR #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmcauliffe
requested changes
Nov 7, 2018
There was a problem hiding this comment.
Basically, I'd like to avoid having submodules as much as possible here. The model for conch is that it calls things that are available on the path and requires them to be built separately. I think removing the submodule will make some extra steps in the travis config necessary (though it's currently erroring out, I'm going to be adding a new commit to fix that error shortly, so pull that in when it's committed and try to get tests on Travis passing).
|
@mmcauliffe the submodule was removed and now it should be good for merging(except for the path thing which we discussed). |
mmcauliffe
approved these changes
Nov 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Autovot support fixing issue #9